Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core Performance Team badge missing from org pages #230

Open
jeffpaul opened this issue Sep 14, 2023 · 3 comments
Open

Core Performance Team badge missing from org pages #230

jeffpaul opened this issue Sep 14, 2023 · 3 comments

Comments

@jeffpaul
Copy link
Member

Looking at https://wordpress.org/five-for-the-future/pledge/10up/ as an example, it includes https://profiles.wordpress.org/joemcgill/ and https://profiles.wordpress.org/jeffpaul/ and https://profiles.wordpress.org/peterwilsoncc/ all of whom have Core Performance badges but those don't flow up and have a Core Performance Team badge on the 10up org page. I'm guessing this is because the Core Performance badges (Contributor, Team) have been newly added, but the handling probably does not exist on the 5ftF org pages?

@jeffpaul
Copy link
Member Author

Looks like Core Performance needs to be added here:

function get_badge_classes( $team ) {

and here:

* Copied from the profiles.wordpress.org theme stylesheet.

@dd32
Copy link
Member

dd32 commented Dec 22, 2023

I'm guessing this is because the Core Performance badges (Contributor, Team) have been newly added, but the handling probably does not exist on the 5ftF org pages?

That seems like a reasonable guess.

The performance team isn't included in the sponsored contributors team list either, ie. the sponsored contributors can't select it here:
https://profiles.wordpress.org/me/profile/edit/group/5/

That list is intentionally not the same as all teams, I don't recall the reason why that's the case. I think it might've been due to not all of the groups in the BP backend are actually contribution teams that a company can sponsor.

I believe these badges reflect the teams that members of the company have specified they contribute hours towards, not simply the badges that the members have received. ie. That's the teams listed in this highlighted section:

Screenshot 2023-12-22 at 3 11 08 pm

So this needs a two-part change:

  1. Contributors need to be able to specify they contribute hours to the team
  2. 5ftf needs the styles for the Core Perf badge

@iandunn
Copy link
Member

iandunn commented Jan 22, 2024

That list is intentionally not the same as all teams, I don't recall the reason why that's the case. I think it might've been due to not all of the groups in the BP backend are actually contribution teams that a company can sponsor.

IIRC, we left out some of the "closed" groups like Security and Plugin Review, since folks who don't contribute to those teams often mistakingly select them. In some cases that's because they wrote a plugin, and didn't understand the distinction.

I created #134 to address team members not having it chosen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants