Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New sign in with every on-site chat #1

Closed
josephahaden opened this issue Nov 29, 2023 · 6 comments · Fixed by Automattic/chatrix#239
Closed

New sign in with every on-site chat #1

josephahaden opened this issue Nov 29, 2023 · 6 comments · Fixed by Automattic/chatrix#239
Assignees
Labels
bug Something isn't working

Comments

@josephahaden
Copy link

Expected Behavior

I was testing the on-site chat integrations this morning and expected to be able to log into the server once and be able to participate in all chats from there.

Actual Behavior

Screenshot 2023-11-29 at 8 43 13 AM

Instead, I get a new sign in for every chat I open. It shows the screen above first, but won't let me reuse any of the sessions. Then when I click "Sign In" it redirects as normal and creates a new one.

Steps to Reproduce

  1. Go to make.wordpress.org
  2. Click a meeting link to go to a room
  3. Go back to make.wordpress.org
  4. Click a different meeting link to go to a different room

Environment

No response

Screenshots

No response

Additional Context

No response

@akirk
Copy link
Collaborator

akirk commented Nov 29, 2023

For some reason, your browser is not reusing the already existing session. Could you please try to log out of all the additional sessions like this?

When presented with the selection, open one of the 4 accounts and you'll arrive inside the room. Then go to settings like this:
Screenshot 2023-11-29 at 15 54 18
and then log out of that session:
Screenshot 2023-11-29 at 15 54 23

When you're down to a single session, it should not prompt you to select one when you open the chat but go into the room straight away.

@josephahaden
Copy link
Author

That worked! I'm now down to one session. 🎉

@psrpinto psrpinto added the bug Something isn't working label Nov 29, 2023
@psrpinto psrpinto self-assigned this Nov 29, 2023
@psrpinto
Copy link
Member

@josephahaden Any chance you remember which page you were at when you logged-in the first time? If so, could you post the URL of the page?

@psrpinto
Copy link
Member

We have identified a solution for this and will be issuing a fix ASAP.

@psrpinto psrpinto linked a pull request Nov 30, 2023 that will close this issue
4 tasks
@psrpinto
Copy link
Member

We have produced a fixed. Reopening for now since it's not yet deployed. Deploying ASAP.

@psrpinto psrpinto reopened this Nov 30, 2023
@psrpinto
Copy link
Member

Fix has been deployed. Users will now never see the "session picker" screen, and will instead automatically be logged-in to an existing session, if there is one.

If user had multiple sessions (as per this issue), all but one will be automatically removed, and they will be logged-in to the remaining one.

Additionally, if there is no session, users will now see the login screen directly, instead of first having to click "Sign in" in the session picker.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: ✅ Done
Development

Successfully merging a pull request may close this issue.

3 participants