Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#core-firehose does not include PR comments #36

Open
peterwilsoncc opened this issue Dec 10, 2023 · 2 comments
Open

#core-firehose does not include PR comments #36

peterwilsoncc opened this issue Dec 10, 2023 · 2 comments

Comments

@peterwilsoncc
Copy link

Expected Behavior

In Slack, the #core-firehose channel, the GitHub bot is configured to show PR reviews and comments in the main channel:

/github subscribe wordpress/wordpress-develop reviews:"channel"
/github subscribe wordpress/wordpress-develop comments:"channel"

I'd like the eqivalent to be set up in the matrix version of the channel

Actual Behavior

The matrix channel does not include reviews or comments in the main channel.

Steps to Reproduce

  1. Go to https://wordpress.slack.com/archives/C0397U3CV/p1702214276325899
  2. Immediately below this is an entry of a PR being closed, then a comment on the PR linking to the source commit.
  3. Go to https://matrix.to/#/!yxdwXnilqyWyySDhuO:community.wordpress.org/$c16Fr-oBsg1KMfKVlduoo4Sj77RerSpGUlg4-7P7QTg?via=community.wordpress.org
  4. Neither the PR closure or comment appear below it.

Environment

Client: Element desktop app
O/S: macOS

Screenshots

Slack
Screen Shot 2023-12-11 at 8 31 41 am

Matrix

Screen Shot 2023-12-11 at 8 32 11 am

Additional Context

No response

@akirk
Copy link
Collaborator

akirk commented Dec 11, 2023

The comments arrive in Matrix, but just in the thread. The issue here is that Matrix (currently?) doesn't have the "Also send to room" function that makes these comments show up as the most recent message in the room. A possible approach would be to just send the message to the room twice of which only one is to the thread.

@peterwilsoncc
Copy link
Author

A possible approach would be to just send the message to the room twice of which only one is to the thread.

I think this would be a good solution until the feature is introduced (or if it is introduced).

To avoid duplicate messages in search, it might be best to drop the posts in threads as they're unlikely to be tracked given the amount of traffic in the firehose & threads being difficult to track once they go off screen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

2 participants