Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Restore tests and fix causes of failure #123

Merged
merged 6 commits into from Jul 2, 2021
Merged

Restore tests and fix causes of failure #123

merged 6 commits into from Jul 2, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Jun 30, 2021

Fixes #122.
Addresses WordPress/openverse#32.

This PR restores tests that will run

  • for every push to main
  • for every PR
  • on demand

It also fixes violations that cause the code style tests to fail.

@dhruvkb dhruvkb requested a review from a team as a code owner June 30, 2021 12:58
@dhruvkb dhruvkb requested review from krysal and obulat June 30, 2021 12:58
@dhruvkb dhruvkb added this to Needs review in Openverse Jun 30, 2021
@dhruvkb dhruvkb added 🌟 goal: addition Addition of new feature 🤖 aspect: dx Concerns developers' experience with the codebase labels Jun 30, 2021
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That "Not a TTY" error was bugging me, nice you sorted it! :)

Openverse automation moved this from Needs review to Reviewer approved Jun 30, 2021
@dhruvkb dhruvkb merged commit 204c85c into main Jul 2, 2021
Openverse automation moved this from Reviewer approved to Done! Jul 2, 2021
@dhruvkb dhruvkb deleted the ci branch July 2, 2021 00:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🌟 goal: addition Addition of new feature
Projects
No open projects
Openverse
  
Done!
Development

Successfully merging this pull request may close these issues.

Run CI jobs on Dependabot PRs
3 participants