Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Limit page depth of searches #857

Closed
1 task
zackkrida opened this issue Aug 5, 2022 · 0 comments · Fixed by #859
Closed
1 task

Limit page depth of searches #857

zackkrida opened this issue Aug 5, 2022 · 0 comments · Fixed by #859
Assignees
@AetherUnbound
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟥 priority: critical Must be addressed ASAP
Projects
Openverse

Comments

@zackkrida
Copy link
Member

Problem

As a temporary fix for some performance issues with the Openverse API, we should cap the max page depth to 20. This means that if a search had 40 pages of results users would still be limited to accessing pages 1-20.

Description

This prevents the scenario described here cc-archive/cccatalog-api#565, which has become an increasing problem with the number of users scraping Openverse's dataset, while we make improvements to pagination and dead link elimination.

Alternatives

Additional context

Implementation

  • 🙋 I would be interested in implementing this feature.
@zackkrida zackkrida added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature labels Aug 5, 2022
@zackkrida zackkrida changed the title Limit search page depth Limit page depth of searches Aug 5, 2022
@openverse-bot openverse-bot added this to Backlog in Openverse Aug 5, 2022
@zackkrida zackkrida added the 🟥 priority: critical Must be addressed ASAP label Aug 5, 2022
@AetherUnbound AetherUnbound added 💻 aspect: code Concerns the software code in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Aug 5, 2022
@AetherUnbound AetherUnbound self-assigned this Aug 5, 2022
@AetherUnbound AetherUnbound moved this from Backlog to In progress in Openverse Aug 5, 2022
This was referenced Aug 5, 2022
Closed
Merged
Openverse automation moved this from In progress to Done! Aug 8, 2022
@sarayourfriend sarayourfriend mentioned this issue Aug 9, 2022
Merged
7 tasks
@AetherUnbound AetherUnbound mentioned this issue Dec 3, 2022
Merged
7 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@AetherUnbound AetherUnbound

Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟥 priority: critical Must be addressed ASAP
Projects
No open projects
Openverse
  
Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Limit page depth of searches WordPress/openverse-api
2 participants
@zackkrida @AetherUnbound