Skip to content
This repository has been archived by the owner on Aug 4, 2023. It is now read-only.

Install pgcli on postgres dev container #224

Closed
1 task
AetherUnbound opened this issue Oct 7, 2021 · 4 comments · Fixed by #252
Closed
1 task

Install pgcli on postgres dev container #224

AetherUnbound opened this issue Oct 7, 2021 · 4 comments · Fixed by #252
Assignees
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed
Projects

Comments

@AetherUnbound
Copy link
Contributor

Description

I've been doing a bit of investigating/troubleshooting on the postgres container we use for local development. Since we're already defining a custom Docker image for it, I would love to add pgcli to the container too. This will give us autocompletion, vim keybindings, and better interactivity with the database.

Additional context

Implementation

  • 🙋 I would be interested in implementing this feature.
@AetherUnbound AetherUnbound added 🟩 priority: low Low priority and doesn't need to be rushed 🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Oct 7, 2021
@AetherUnbound AetherUnbound added this to Backlog in Openverse via automation Oct 7, 2021
@dhruvkb
Copy link
Member

dhruvkb commented Oct 7, 2021

@AetherUnbound I'm generally of the mind that our images should be as lean as possible with only the essential tooling present in the containers. Is it possible to make a different dev image while keeping the prod image minimal?

@zackkrida
Copy link
Member

In this case @dhruvkb the postgres container is exclusively used in local development.

@dhruvkb
Copy link
Member

dhruvkb commented Oct 7, 2021

Oh yes, my bad. Thanks for clarifying!

@AetherUnbound
Copy link
Contributor Author

Yes, what @zackkrida said! I totally agree with you, we shouldn't pile anything extra into production images 🙂

@AetherUnbound AetherUnbound self-assigned this Oct 15, 2021
@AetherUnbound AetherUnbound moved this from Backlog to To do in Openverse Oct 15, 2021
@AetherUnbound AetherUnbound moved this from To do to In progress in Openverse Oct 15, 2021
Openverse automation moved this from In progress to Done! Oct 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🧰 goal: internal improvement Improvement that benefits maintainers, not users 🟩 priority: low Low priority and doesn't need to be rushed
Projects
No open projects
Openverse
  
Done!
Development

Successfully merging a pull request may close this issue.

3 participants