Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

[Feature] i18n English strings for results count #130

Closed
1 task done
obulat opened this issue Aug 16, 2021 · 0 comments · Fixed by #131
Closed
1 task done

[Feature] i18n English strings for results count #130

obulat opened this issue Aug 16, 2021 · 0 comments · Fixed by #131
Labels
📄 aspect: text Concerns the textual material in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects

Comments

@obulat
Copy link
Contributor

obulat commented Aug 16, 2021

Problem

The search result page shows number of search results incorrectly.

Description

Instead of "n images" and "Over n images" we can write "[Over] n image results". After adding audio, we will also use "[Over] n audio results" for audio search, and "[Over] n results" for the 'All media types' search.

To ensure correct word pluralization and correct number formatting in other languages, we need to pass the count to the vue-i18n both as a Number, and a localized string representation (eg. 11,500 for English, 11 500 for Russian, and ١١٬٥٠٠ for Arabic)

Alternatives

Leaving it "as-is" will show incorrect result count phrase on the search page for many languages.

Additional context

Implementation

  • 🙋 I would be interested in implementing this feature.
@obulat obulat added 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Aug 16, 2021
@dhruvkb dhruvkb added this to Backlog in Openverse Aug 16, 2021
@obulat obulat added enhancement 📄 aspect: text Concerns the textual material in the repository and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 💻 aspect: code Concerns the software code in the repository labels Aug 16, 2021
@dhruvkb dhruvkb moved this from Backlog to In progress in Openverse Aug 16, 2021
Openverse automation moved this from In progress to Done! Aug 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📄 aspect: text Concerns the textual material in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
No open projects
Openverse
  
Done!
Development

Successfully merging a pull request may close this issue.

1 participant