Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Use v-deep correctly #1634

Closed
1 task done
obulat opened this issue Aug 9, 2022 · 0 comments · Fixed by #1635
Closed
1 task done

Use v-deep correctly #1634

obulat opened this issue Aug 9, 2022 · 0 comments · Fixed by #1635
Assignees
@obulat
Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed
Projects
Openverse

Comments

@obulat
Copy link
Contributor

obulat commented Aug 9, 2022 •
edited

Problem

v-deep was previously used as a combinator selector (i.e., it was written before another CSS selector. Now, it was converted to a pseudo-class.

Description

In VErrorImage, replace the ::v-deep some-selector declarations with ::v-deep(some-selector) style declarations.

Implementation

  • 🙋 I would be interested in implementing this feature.
@obulat obulat added good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users labels Aug 9, 2022
@openverse-bot openverse-bot added this to Backlog in Openverse Aug 9, 2022
@obulat obulat mentioned this issue Aug 23, 2022
Merged
7 tasks
@obulat obulat linked a pull request Aug 23, 2022 that will close this issue
Update Vue to v2.7 #1635
Merged
7 tasks
@openverse-bot openverse-bot moved this from Backlog to In progress in Openverse Aug 23, 2022
@obulat obulat self-assigned this Aug 23, 2022
Openverse automation moved this from In progress to Done! Aug 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@obulat obulat

Labels
💻 aspect: code Concerns the software code in the repository 🧰 goal: internal improvement Improvement that benefits maintainers, not users good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed
Projects
No open projects
Openverse
  
Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update Vue to v2.7 WordPress/openverse-frontend
1 participant
@obulat