Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

The external sources on the No results form should not be in a popover #1999

Closed
1 task
obulat opened this issue Nov 21, 2022 · 1 comment · Fixed by #2077
Closed
1 task

The external sources on the No results form should not be in a popover #1999

obulat opened this issue Nov 21, 2022 · 1 comment · Fixed by #2077
Assignees
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects

Comments

@obulat
Copy link
Contributor

obulat commented Nov 21, 2022

Problem

The external search feature shown on the "No results" page should show a row (or column for mobile) of button links to the external sources.

Screenshot 2022-11-21 at 4 56 38 PM

Screenshot 2022-11-21 at 5 19 18 PM

Figma link desktop: https://www.figma.com/file/w60dl1XPUvSaRncv1Utmnb/Audio-Release?node-id=1479%3A20812&t=JjmB63Y8kMIIlwm3-4
Figma link mobile: https://www.figma.com/file/w60dl1XPUvSaRncv1Utmnb/Audio-Release?node-id=1479%3A20846&t=3szwykXToMs7gluh-4

Description

We need to refactorVExternalSourcesList so that the buttons can be used both in a popover and in a row/column. Then, we should replace the popover component on the No results list with the button row/column for the external sources.

Additional context

Split from #734

Implementation

  • 🙋 I would be interested in implementing this feature.
@obulat obulat added 🟨 priority: medium Not blocking but should be addressed soon ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software labels Nov 21, 2022
@obulat obulat added this to the Interface fixes milestone Nov 21, 2022
@openverse-bot openverse-bot added this to Backlog in Openverse Nov 21, 2022
@fcoveram
Copy link

⚠️ Design note

Since the Audio release Figma file linked in the ticket has outdated elements due to many styles were changed after its creation, there are two crucial points to take in mind before developing the change:

  1. All texts need to have the latest text styles applied.
  2. Source buttons must follow the secondary button style in medium size, plus the external icon. The Design Library has not been updated with the icon variant, but the change is pending.

@obulat obulat moved this from Backlog to To do in Openverse Dec 13, 2022
@obulat obulat self-assigned this Dec 13, 2022
@openverse-bot openverse-bot moved this from To do to In progress in Openverse Dec 30, 2022
Openverse automation moved this from In progress to Done! Jan 31, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
No open projects
Openverse
  
Done!
Development

Successfully merging a pull request may close this issue.

2 participants