Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

App shows "no results for {query}" while results are loading #383

Closed
zackkrida opened this issue Oct 28, 2021 · 2 comments · Fixed by #382 or #398
Closed

App shows "no results for {query}" while results are loading #383

zackkrida opened this issue Oct 28, 2021 · 2 comments · Fixed by #382 or #398
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects

Comments

@zackkrida
Copy link
Member

Description

While the current search is loading, the application says there are no results available. This could confuse users on slow network speeds.

This will be helped when we have placeholder loading ui that pushes the meta search down, but we should still fix this. I consider it a state management issue—the application shouldn't think there are 'no results' until a search has been completed.

CleanShot 2021-10-28 at 12 39 04@2x

@zackkrida zackkrida added 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Oct 28, 2021
@dhruvkb dhruvkb added this to Backlog in Openverse Oct 28, 2021
@obulat
Copy link
Contributor

obulat commented Oct 28, 2021

Thus might be fixed in #382, by having a mediaFetchState object with a fetchError property which is either null or has a value of error message, similar to the Nuxt's $fetchState

@zackkrida
Copy link
Member Author

@obulat yes, it is fixed there! Excellent 👍

@dhruvkb dhruvkb moved this from Backlog to In progress in Openverse Oct 28, 2021
Openverse automation moved this from In progress to Done! Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
No open projects
Openverse
  
Done!
2 participants