Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

404 page doesn't respect 'embedded' mode #487

Closed
zackkrida opened this issue Dec 6, 2021 · 2 comments
Closed

404 page doesn't respect 'embedded' mode #487

zackkrida opened this issue Dec 6, 2021 · 2 comments
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
Openverse
Milestone
Redesign

Comments

@zackkrida
Copy link
Member

zackkrida commented Dec 6, 2021 •
edited

Description

The current 404 layout in Nuxt doesn't use embedded mode like the other layouts do.

Related to #256

Reproduction

  1. Go to a nonexistient page (wordpress.org/openverse/random)
  2. Observe the non-embedded styles:

CleanShot 2021-12-06 at 09 35 00@2x

Expectation

This page should show the same header and layout as the rest of the site when in embedded mode.
@zackkrida zackkrida added 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository 🟨 priority: medium Not blocking but should be addressed soon and removed 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work labels Dec 6, 2021
@zackkrida zackkrida added this to the Redesign milestone Dec 6, 2021
@dhruvkb dhruvkb added this to Backlog in Openverse Dec 6, 2021
@zackkrida zackkrida added the 💬 talk: discussion Open for discussions and feedback label Dec 7, 2021
@dhruvkb
Copy link
Member

dhruvkb commented Dec 7, 2021

Relates to #256.

@AetherUnbound AetherUnbound removed the 💬 talk: discussion Open for discussions and feedback label Dec 7, 2021
@zackkrida
Copy link
Member Author

Closing, as this is fixed via #256

Openverse automation moved this from Backlog to Done! Jan 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
No open projects
Openverse
  
Done!
Milestone
Redesign
Development

No branches or pull requests
3 participants
@zackkrida @AetherUnbound @dhruvkb