Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Query text has whitespace around quotes when no content is found #538

Closed
1 task
AetherUnbound opened this issue Dec 17, 2021 · 2 comments · Fixed by #553
Closed
1 task

Query text has whitespace around quotes when no content is found #538

AetherUnbound opened this issue Dec 17, 2021 · 2 comments · Fixed by #553
Assignees
@dhruvkb
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon
Projects
Openverse

Comments

@AetherUnbound
Copy link
Contributor

AetherUnbound commented Dec 17, 2021 •
edited by zackkrida

Description

When no results are found, the search term gets shown as No image results for " <word> ", with the additional whitespace between the quote characters and the word. This can be confusing, since it might lead users to believe they had whitespace in their original search term and that was why no images could be found.

Reproduction

  1. Make a search for a term that does not bring back any replies
  2. Observe the spaces between the quote character and the search term

Expectation

The quotes should wrap the term exactly, e.g. "<word>" rather than " <word> ".

Screenshots

image

Environment

  • Device: Desktop
  • OS: Xubuntu 18.04
  • Browser: Firefox

Additional context

The meta search form is the related component: https://github.com/WordPress/openverse-frontend/blob/91f79fdc4eec4c33e9a8e6e347f1e5ee0b4e07a7/src/components/VMetaSearch/VMetaSearchForm.vue

Resolution

  • 🙋 I would be interested in resolving this bug.
@AetherUnbound AetherUnbound added 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Dec 17, 2021
@dhruvkb dhruvkb added this to Backlog in Openverse Dec 17, 2021
@zackkrida
Copy link
Member

zackkrida commented Dec 17, 2021 •
edited

I believe this is fixed in main but we can leave this open until that is redeployed and confirmed!

Lies! Yes, it's a simple whitespace fix, very silly.

@zackkrida zackkrida added good first issue New-contributor friendly help wanted Open to participation from the community labels Dec 17, 2021
@hasanuzzamanbe
Copy link
Contributor

I think this problem related to Vue-i18n
Here are some discussions:
kazupon/vue-i18n#963

@dhruvkb dhruvkb mentioned this issue Dec 23, 2021
Merged
7 tasks
@dhruvkb dhruvkb self-assigned this Dec 23, 2021
Openverse automation moved this from Backlog to Done! Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dhruvkb dhruvkb

Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon
Projects
No open projects
Openverse
  
Done!
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove stray whitespace WordPress/openverse-frontend
4 participants
@zackkrida @AetherUnbound @dhruvkb @hasanuzzamanbe