Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add types to utils/math.js #933

Closed
1 task
sarayourfriend opened this issue Feb 21, 2022 · 0 comments · Fixed by #1052
Closed
1 task

Add types to utils/math.js #933

sarayourfriend opened this issue Feb 21, 2022 · 0 comments · Fixed by #1052
Assignees
@dhruvkb
Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed
Projects
Openverse
Milestone
TypeScriptification

Comments

@sarayourfriend
Copy link
Contributor

Description

Add type checking to math.js. This module has zero dependencies and is already type annotated. Add it to tsconfig.json's include list and fix any type errors that arise.

Additional context

Part of an ongoing effort to add type checking to parts of the project that can be type checked.

Implementation

  • 🙋 I would be interested in implementing this feature.
@sarayourfriend sarayourfriend added good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work ✨ goal: improvement Improvement to an existing user-facing feature 💻 aspect: code Concerns the software code in the repository labels Feb 21, 2022
@sarayourfriend sarayourfriend added this to the TypeScriptification milestone Feb 21, 2022
@dhruvkb dhruvkb added this to Backlog in Openverse Feb 21, 2022
@sarayourfriend sarayourfriend removed the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Feb 21, 2022
@dhruvkb dhruvkb self-assigned this Mar 4, 2022
@dhruvkb dhruvkb mentioned this issue Mar 4, 2022
Merged
7 tasks
@dhruvkb dhruvkb moved this from Backlog to In progress in Openverse Mar 4, 2022
Openverse automation moved this from In progress to Done! Mar 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@dhruvkb dhruvkb

Labels
💻 aspect: code Concerns the software code in the repository ✨ goal: improvement Improvement to an existing user-facing feature good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed
Projects
No open projects
Openverse
  
Done!
Milestone
TypeScriptification
Development

Successfully merging a pull request may close this issue.

Convert more utils to TypeScript WordPress/openverse-frontend
2 participants
@dhruvkb @sarayourfriend