Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync issue in confirm box in pattern directory page #546

Closed
mayurbaroliya-multidots opened this issue Jan 4, 2023 · 6 comments
Closed
Assignees
Labels
[Component] Pattern Creator Anything related to the pattern front end editor or preview [Type] Bug Something isn't working

Comments

@mayurbaroliya-multidots
Copy link

Describe the bug

While creating the pattern, if I'm editing the existing pattern then I have this type of error confirm box and the changes is gone.

To Reproduce
Steps to reproduce the behavior:

  1. Go to (https://wordpress.org/patterns/pattern/253951/edit/)
  2. See error

Screenshots
https://share.cleanshot.com/7kc615t9Bt4n9M16DDtK

Desktop (please complete the following information):

  • OS: [mac OS]
  • Browser [chrome, safari]
@ryelle
Copy link
Contributor

ryelle commented Jan 4, 2023

This is working for me on Mac + Chrome. Can you click the "Copy Error" button and paste the result here?

@ryelle ryelle added [Type] Bug Something isn't working [Status] Needs Reporter Feedback and removed [Type] Bug Something isn't working labels Jan 4, 2023
@StevenDufresne
Copy link
Collaborator

A similar issue has been reported in meta trac:

https://meta.trac.wordpress.org/ticket/6657

@mayurbaroliya-multidots
Copy link
Author

mayurbaroliya-multidots commented Jan 5, 2023

While clicking on the copy error, I have below errors. I am also using mac OS and chrome browser.

TypeError: Cannot read properties of null (reading 'isSynced') at e (https://wordpress.org/patterns/wp-content/plugins/gutenberg/build/block-editor/index.min.js?ver=036b8eab6943588f121a:90:820) at wt (https://wordpress.org/patterns/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:47623) at vr (https://wordpress.org/patterns/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:56438) at mr (https://wordpress.org/patterns/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:55646) at $s (https://wordpress.org/patterns/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:124104) at wl (https://wordpress.org/patterns/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:88644) at bl (https://wordpress.org/patterns/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:88572) at yl (https://wordpress.org/patterns/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:88435) at fl (https://wordpress.org/patterns/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:85592) at zn (https://wordpress.org/patterns/wp-content/plugins/gutenberg/build/vendors/react-dom.min.js?ver=18:1:32460)

@ryelle
Copy link
Contributor

ryelle commented Jan 5, 2023

I've tried some older Gutenberg versions and it looks like this starts happening at 14.7. Not sure yet what changed to make this crash.

@ryelle ryelle added [Type] Bug Something isn't working [Component] Pattern Creator Anything related to the pattern front end editor or preview and removed [Status] Needs Reporter Feedback labels Jan 6, 2023
@ryelle ryelle self-assigned this Jan 6, 2023
@ryelle ryelle closed this as completed in d18e3e2 Jan 6, 2023
@ryelle
Copy link
Contributor

ryelle commented Jan 6, 2023

I think I've found and fixed the cause of this issue, so this should be working correctly now.

@mayurbaroliya-multidots
Copy link
Author

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Pattern Creator Anything related to the pattern front end editor or preview [Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants