Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block theme: How do I clear my filtered search? #669

Closed
StevenDufresne opened this issue Apr 15, 2024 · 6 comments
Closed

Block theme: How do I clear my filtered search? #669

StevenDufresne opened this issue Apr 15, 2024 · 6 comments
Labels
[Component] Theme The frontend of the pattern directory, pattern lists UI [Status] Needs Design Feedback

Comments

@StevenDufresne
Copy link
Collaborator

Describe the bug
We no longer have an "all" category. If I click Featured, and search, it will search for the keyword inside the Featured category. That is expected.

How do I search for my keyword amongst all the categories if I have already selected one? Start here for example.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://wordpress.org/patterns/?new-theme=1
  2. Click on Featured
  3. Search for pricing
  4. Notice the result set is relevant.
  5. Try to search all patterns now.
@StevenDufresne StevenDufresne changed the title Block theme: How do i clear me filtered search? Block theme: How do I clear my filtered search? Apr 15, 2024
@ryelle
Copy link
Contributor

ryelle commented Apr 15, 2024

You can back out using the breadcrumbs to get back to the "All patterns" page, so it's not impossible - but not exactly obvious either.

Screen Shot 2024-04-15 at 11 26 56

@WordPress/meta-design What do you think?

@ryelle ryelle added [Component] Theme The frontend of the pattern directory, pattern lists UI [Status] Needs Design Feedback labels Apr 15, 2024
@jasmussen
Copy link

I'd tend to echo Kelly that the breadcrumbs work reasonably for this, and the bery visible active state for the particular tab you're in is good indication of context. I also didn't mind having the "All" tab.

@StevenDufresne
Copy link
Collaborator Author

Although we have technically navigated to a new page, I don't think users consciously note the navigation when they click on a category link, especially given how most modern directories are single-page web pages with no post-back.

As @ryelle mentions, I agree that reversing filtering by navigating to a new page doesn't feel obvious.

Assuming this is where the "all' button was removed, I would suggest we add it back.

@fcoveram
Copy link

Assuming WordPress/wporg-parent-2021#127 (comment), I would suggest we add it back.

True. Removing the "All" tab came from a conversation about the multiple selection flow where "all options selected" shows the same results as "all options unselected". The single selection demands an option to show everything, and the current demo site has it correctly. Screenshot below.


Therefore, and since tabs behave as single selection views, it makes sense to bring back the "All" option.

Landing on the page with all items from a breadcrumb link is definitely a tricky interaction. Although the breadcrumb has the link included, its purpose is primarily about site location. Due to the interaction context, the "All" tab should be next to the rest in the first position.

@ryelle
Copy link
Contributor

ryelle commented Apr 16, 2024

Okay, I'll bring back the "All" option in the category nav menu 🙂

@ryelle ryelle closed this as completed in e537af2 Apr 16, 2024
@ryelle
Copy link
Contributor

ryelle commented Apr 16, 2024

I've added "All" back to the category menu & the status menu:

Home
Screenshot 2024-04-16 at 11 29 29 AM

My Patterns
Screenshot 2024-04-16 at 11 29 36 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Component] Theme The frontend of the pattern directory, pattern lists UI [Status] Needs Design Feedback
Projects
Status: Done
Development

No branches or pull requests

4 participants