Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a build process for the plugins directory plugin. #1006

Closed
Tracked by #656
mukeshpanchal27 opened this issue Feb 22, 2024 · 3 comments
Closed
Tracked by #656

Add a build process for the plugins directory plugin. #1006

mukeshpanchal27 opened this issue Feb 22, 2024 · 3 comments
Assignees
Labels
Creating standalone plugins Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature

Comments

@mukeshpanchal27
Copy link
Member

Follow-up: #1000 (comment)

Currently, for the deploy process, we added plugin versions per #935 (comment). However, as per @westonruter's feedback in #1000 (comment), we should avoid defining the version in three places (plugin main file, readme file, and plugins.json file). We need to think of a better workflow to manage their version in a single place to avoid updating in multiple places.

@mukeshpanchal27 mukeshpanchal27 added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure Creating standalone plugins labels Feb 22, 2024
@thelovekesh
Copy link
Member

@mukeshpanchal27 @westonruter I will be picking up this as we are doing something similar at #893

@thelovekesh thelovekesh self-assigned this Feb 22, 2024
@felixarntz
Copy link
Member

@mukeshpanchal27 Just spotting this, I believe this is addressing the same concern I just voiced in #935 (comment)?

@mukeshpanchal27
Copy link
Member Author

Yes. Closing this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Creating standalone plugins Infrastructure Issues for the overall performance plugin infrastructure [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

No branches or pull requests

3 participants