Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setting screen tooltip should go away after visiting the settings page #1135

Closed
adamsilverstein opened this issue Apr 15, 2024 · 4 comments · Fixed by #1147
Closed

Setting screen tooltip should go away after visiting the settings page #1135

adamsilverstein opened this issue Apr 15, 2024 · 4 comments · Fixed by #1147
Labels
Good First Issue Issue particularly suitable to be worked on by new contributors [Type] Bug An existing feature is broken
Milestone
performance-lab 3...

Comments

@adamsilverstein
Copy link
Member

Bug Description

The tool tip guiding users to the settings page shows even after they visit it. Instead, it should go away as if "Dismiss" was clicked.

This tooltip pops up when the user installs the plugin so they can more easily find the settings screen:

image

Once the user clicks the "Settings > Performance" link in the tooltip, or otherwise visits the settings page, we should no longer show the tooltip.

Steps to reproduce

  1. Install the plugin
  2. Click "Settings > Performance" in the tooltip to visit the settings page
  3. Go back and visit the Dashboard

Expected results: the tooltip should no longer show
Actual results: the tooltip is still showing
@adamsilverstein adamsilverstein added the [Type] Bug An existing feature is broken label Apr 15, 2024
@westonruter westonruter added this to the performance-lab 3.1.0 milestone Apr 15, 2024
@westonruter westonruter added the Good First Issue Issue particularly suitable to be worked on by new contributors label Apr 15, 2024
@Ellusu
Copy link
Contributor

Ellusu commented Apr 15, 2024

I'll work on it

@adamsilverstein
Copy link
Member Author

Thanks @Ellusu!

@Ellusu Ellusu mentioned this issue Apr 16, 2024
Merged
@Ellusu
Copy link
Contributor

Ellusu commented Apr 16, 2024

I created: #1147 Grazie

@mukeshpanchal27
Copy link
Member

Closed in #1147

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Good First Issue Issue particularly suitable to be worked on by new contributors [Type] Bug An existing feature is broken
Projects
None yet
Milestone
performance-lab 3.1.0
Development

Successfully merging a pull request may close this issue.

Do not show on the settings page and dismiss the pointer Ellusu/performance
4 participants
@westonruter @adamsilverstein @Ellusu @mukeshpanchal27