Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Progress indicator is missing when activating a feature #1139

Closed
westonruter opened this issue Apr 15, 2024 · 3 comments · Fixed by #1190
Closed

Progress indicator is missing when activating a feature #1139

westonruter opened this issue Apr 15, 2024 · 3 comments · Fixed by #1190
Assignees
Labels
Performance Lab Plugin Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature

Comments

@westonruter
Copy link
Member

Feature Description

When activating a feature on the Performance screen, there can be quite a bit of delay between the initial click and the page reloading with the success admin notice:

Screen.recording.2024-04-15.10.18.42.webm

This is because activating a feature may involve installing a plugin first before activating the plugin. There should be some spinner that appears with the Activate button that was clicked. Also, the other features' Activate buttons should also be disabled while this reload process is happening.

Perhaps better would be to use an Ajax process to activate the plugin rather than to do a full page reload. This would allow a user to click to activate multiple features without having to wait for a page reload (e.g. shiny updates).

@westonruter westonruter added [Type] Enhancement A suggestion for improvement of an existing feature Performance Lab Plugin Issue relates to work in the Performance Lab Plugin only labels Apr 15, 2024
@westonruter westonruter added this to the performance-lab 3.1.0 milestone Apr 15, 2024
@mukeshpanchal27
Copy link
Member

In #1091, I initially used the AJAX approach for installation and activation. However, based on the feedback #1091 (comment), I changed it to reload. In the AJAX approach, I added a loading button. If we agree to use AJAX, then I'm happy to open a PR that uses that approach.

@westonruter
Copy link
Member Author

See video in #1184 (for features with plugin dependencies) which shows further need for a spinner.

@westonruter
Copy link
Member Author

@mukeshpanchal27 Let's start with just the spinner as the quick fix, and then we can go with Ajax next.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Lab Plugin Issue relates to work in the Performance Lab Plugin only [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants