Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve Settings for Modern Image Formats #1258

Closed
adamsilverstein opened this issue May 30, 2024 · 2 comments · Fixed by #1273
Closed

Improve Settings for Modern Image Formats #1258

adamsilverstein opened this issue May 30, 2024 · 2 comments · Fixed by #1273
Assignees
@adamsilverstein
Labels
[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Enhancement A suggestion for improvement of an existing feature
Milestone
webp-uploads 2.0.0

Comments

@adamsilverstein
Copy link
Member

Feature Description

Since adding AVIF and <picture> element support, some potential improvements to the settings screen became apparent.

Potential Improvements

  • As @joemcgill mentioned in Add picture element support #73 (comment) we should properly handle sites that lack both AVIF and WebP support (~2% of sites).
  • <picture> element support is only useful when there is both a modern format (WebP/AVIF) and a JPEG fallback available for each sub size, eg. when the "Also output JPEG images" setting is enabled. Therefore, maybe the picture element support toggle should only be enabled when JPEGs are being generated? (and otherwise displayed in a greyed out "disabled" state)
@adamsilverstein adamsilverstein added [Type] Enhancement A suggestion for improvement of an existing feature [Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) no milestone PRs that do not have a defined milestone for release labels May 30, 2024
@adamsilverstein adamsilverstein mentioned this issue May 30, 2024
Merged
@westonruter westonruter added this to the webp-uploads 2.0.0 milestone May 30, 2024
@westonruter
Copy link
Member

@adamsilverstein Good points. Could this be done for the next release on June 6th?

@adamsilverstein
Copy link
Member Author

@adamsilverstein Good points. Could this be done for the next release on June 6th?

Sure I am happy to work on this unless someone else wants to pick it up!

@adamsilverstein adamsilverstein mentioned this issue Jun 4, 2024
Merged
@westonruter westonruter removed the no milestone PRs that do not have a defined milestone for release label Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamsilverstein adamsilverstein

Labels
[Plugin] Modern Image Formats Issues for the Modern Image Formats plugin (formerly WebP Uploads) [Type] Enhancement A suggestion for improvement of an existing feature
Projects
WP Performance 2024
Status: Done 😃
Milestone
webp-uploads 2.0.0
Development

Successfully merging a pull request may close this issue.

Improve Settings->Media controls for Modern Image Formats adamsilverstein/performance
2 participants
@westonruter @adamsilverstein