Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create Autoloaded Options Core Documentation #234

Closed
manuelRod opened this issue Mar 18, 2022 · 16 comments
Closed

Create Autoloaded Options Core Documentation #234

manuelRod opened this issue Mar 18, 2022 · 16 comments
Assignees
Labels
[Plugin] Audit Autoloaded Options Issues for the Audit Autoloaded Options Health Check module [Type] Documentation Documentation to be added or enhanced

Comments

@manuelRod
Copy link
Contributor

manuelRod commented Mar 18, 2022

Feature Description

As a #92 follow-up, as we cannot rely only on hosting using the filters to link to their own information/recommendation, we need to offer a default link with some call to action on how to solve the problem.

The consensus was we should use the following article Maybe using #autoload anchor. https://wordpress.org/support/article/optimization/#autoload
In this topic, we need to explain the why and how to solve it.

Hosting article examples:
Kinsta
WPEngine
Pantheon
...

@tillkruss
Copy link
Member

Related #163

@felixarntz felixarntz added [Type] Documentation Documentation to be added or enhanced [Plugin] Audit Autoloaded Options Issues for the Audit Autoloaded Options Health Check module labels Mar 18, 2022
@bethanylang bethanylang self-assigned this Mar 24, 2022
@bethanylang
Copy link
Contributor

@manuelRod I’m happy to work an initial draft for this!

@bethanylang bethanylang moved this from To do to In progress in [Focus] Site Health LEGACY Mar 29, 2022
@bethanylang
Copy link
Contributor

@manuelRod @felixarntz I've prepared an initial draft here: https://docs.google.com/document/d/1LyEDpAvqDcE_vAJNJRioe_2LrorOZt9NMoetBzYC3Vw/edit?usp=sharing. This follows the general format of the different sections in the overall Optimization guide in that it does not provide step-by-step instructions, but gives a broad overview of the issue and then directs the user to further reading. Let me know what you think.

@bethanylang bethanylang moved this from In progress to Review in [Focus] Site Health LEGACY Apr 1, 2022
@manuelRod
Copy link
Contributor Author

@bethanylang should we recap more guides from different hosting? so we cover most cases. ?

@bethanylang
Copy link
Contributor

Thanks for reviewing, @manuelRod! I replied to your comments.

The other sections in the Optimization guide tend to only include 4-5 examples per section, so I think it makes sense to keep in line with that and only share a few examples that are from hosting providers that we know are popular. I think adding in too many could make it difficult for folks to find what they're looking for.

@felixarntz Over to you!

@manuelRod
Copy link
Contributor Author

Thanks for the changes @bethanylang I like it, good to go from my side!

@bethanylang
Copy link
Contributor

@felixarntz Circling back on this – if you have a moment to take a look at the doc and give your okay, I can then work on getting this added.

@felixarntz
Copy link
Member

@bethanylang Review the draft, overall looks solid to me! I left one comment with a suggestion.

@zzap We would like to add the section in the doc to https://wordpress.org/support/. Is that something you could potentially help with? We're not entirely sure what the next steps would be.

@zzap
Copy link
Member

zzap commented May 27, 2022

Hi @felixarntz, thanks for pinging me. Yes, we can and should add that. I can help with everything needed.

For now, the easiest thing to do is to open new issue in Docs repo. I created new label for you, performance so you can combine it with developer documentation or user documentation, depending on where you want to add your docs.

For the next steps, I'm gonna reply in slack as there is more context and we can definitely discuss the possible workflow at WCEU.

@bethanylang
Copy link
Contributor

Thanks @zzap! I've opened WordPress/Documentation-Issue-Tracker#358, but it doesn't appear that I can change the label; let me know if there's anything that I need to do there.

@bethanylang bethanylang removed the Needs Review Anything that requires code review label Jun 7, 2022
@manuelRod
Copy link
Contributor Author

@bethanylang I see this already published, but without the links due to the external link policy (to clarify). Should we move forward with the module to point to the article or do we want to wait until clarification?

@bethanylang
Copy link
Contributor

@manuelRod I'd like to hold on clarification for now, as I personally find the links quite important in terms of providing concrete next steps for users. But don't worry, this is on my radar to continue to follow up and file an issue to remove the "experimental" label once we confirm!

@OllieJones
Copy link
Contributor

A bit late to this party (if I'm too late, Never Mind this remark). I suggest editing the article to mention persistent object caching. https://developer.wordpress.org/reference/classes/wp_object_cache/#persistent-caching

@bethanylang
Copy link
Contributor

Thanks @OllieJones! Did you have a particular mention in mind? The intention behind updating this article was to provide some guidance to non-technical users on how to address the results of the autoloaded options health check, so just want to make sure that whatever we add will be helpful for that audience.

@manuelRod Once I get an idea on next steps from Ollie above, I'm going to mark this issue as closed since the documentation is now complete and linked in v1.3.0, released today. We have #409 for the question of removing the Experimental label from this module. Thanks!

@OllieJones
Copy link
Contributor

Sure, here's a draft of what I'm thinking of. I'm cribbing it from a page on developer.wordpress.org @tillkruss should definitely review this stuff, it's his baby.


To the Caching section, add a subsection after Browser caching.

Persistent Object Caching

Persistent Object Caching helps speed up page load times by saving on trips to the database from your web server. For example, your site's options data needs to be available for each page view. Without it, your web server must read those options from the database to handle every page view. Those extra trips to the database slow down your web server and your database server.

For your site to use persistent object caching, your hosting provider must offer you a particular type of server: a cache server. Popular cache servers are Redis and Memcached. Ask your hosting provider to help you install and configure a persistent object cache: they will recommend the right plugin. Here are some.

  • Memcached Object Cache provides a persistent backend for the WordPress object cache. A memcached server and the PECL memcached extension are required.
  • Redis Object Cache supports the use of Predis (PHP client library), HHVM’s Redis extension and the PECL Redis extension to provide a persistent backend for the WordPress object cache. Redis is required.
  • W3 Total Cache provides object level caching using disk, opcode or memcache(d) memory stores. W3TC also provides: browser, page and database caching, in addition to Content Delivery Network Support, Mobile Support, Minification and more.
  • LiteSpeed Cache supports the use of Redis, Memcached, and LSMCD object caches. LSCWP also provides server-level full-page caching, support for browser cache and CDN, and other optimization features. LiteSpeed Web Server required.

To the Further Reading section add this line item


To the autoloaded options add a third one-sentence paragraph.

If you use a Persistent Object Cache, options (whether autoloaded or not) load faster and more efficiently.

@bethanylang
Copy link
Contributor

Thanks @OllieJones! I'm actually going to open a few new issues for this: 1) to add this new documentation and 2) to link to it from the Autoloaded Options health check. I'll also move your proposed documentation into a Google doc and share it so that folks can more easily comment.

Closing this issue and will tag folks on the new ones.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Plugin] Audit Autoloaded Options Issues for the Audit Autoloaded Options Health Check module [Type] Documentation Documentation to be added or enhanced
Projects
No open projects
Development

No branches or pull requests

6 participants