Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable Server Timing via filter #628

Closed
tillkruss opened this issue Jan 24, 2023 · 1 comment · Fixed by #629
Closed

Disable Server Timing via filter #628

tillkruss opened this issue Jan 24, 2023 · 1 comment · Fixed by #629
Assignees
Labels
[Focus] Measurement Issues related to the Measurement focus area Performance Lab Plugin Issue relates to work in the Performance Lab Plugin only
Milestone

Comments

@tillkruss
Copy link
Member

Feature Description

Object Cache Pro and Redis Object Cache both allow users to enable and disable the Redis cache via CLI and UI.

This plugin hijacking the object-cache.php file prevents that core functionality.

I’d like to disable the Server Timing hijack using a filter, not a constant, from my plugins.

It created an unnecessary support burden over the past weeks.

@tillkruss tillkruss added the [Focus] Measurement Issues related to the Measurement focus area label Jan 24, 2023
@eclarke1 eclarke1 added this to Backlog in [Focus] Measurement via automation Jan 24, 2023
@OllieJones
Copy link
Contributor

My fairly new object cache plugin, modeled on Till's, has this FAQ https://wordpress.org/plugins/sqlite-object-cache/#can%20i%20use%20this%20with%20the%20performance%20lab%20plugin%3F

At drop-in load time, ordinary plugins haven't had a chance to register hooks.

With respect, I think this approach of borrowing the drop-in is not workable for widespread production.

@tillkruss tillkruss moved this from Backlog to To do in [Focus] Measurement Jan 24, 2023
@felixarntz felixarntz added this to the 2.0.0 milestone Jan 24, 2023
@felixarntz felixarntz added the Performance Lab Plugin Issue relates to work in the Performance Lab Plugin only label Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Measurement Issues related to the Measurement focus area Performance Lab Plugin Issue relates to work in the Performance Lab Plugin only
Projects
Development

Successfully merging a pull request may close this issue.

3 participants