Dev notes for WordPress 6.4

[eclarke1]

This ticket is used to capture the Trac tickets for WordPress 6.4 that require Dev Notes. See the full list on Trac.

Individual ticket dev notes

• REST API index does not respect fields @spacedmonkey <- Call out in field guide.
• Double sanitization in get_term function @spacedmonkey <- Call out in field guide.
• Remove usage of outputting styles tags (dev note) @spacedmonkey
• Theme: use the_header_image_tag in core themes (does not require a dev note)

Dev notes encompassing multiple tickets

• Object caching dev note
  • WP_Posts_List_Table causes post, postmeta, and term caches to be primed for all pages in the DB on load @spacedmonkey
  • WP_Query->get_posts: cache updated also when query is set to be not cacheable @spacedmonkey
  • Force split queries in WP_Query in object caching is enabled @spacedmonkey
  • Change the position of notoptions lookup in get_option @spacedmonkey
  • Taxonomy: Make it possible to bypass automatic caching of results in get_terms() @spacedmonkey
  • rest_{$this->taxonomy}_query Cache Problem @spacedmonkey
• Template dev note
  • Deprecate TEMPLATEPATH and STYLESHEETPATH
  • Performance issues in _register_theme_block_patterns @spacedmonkey
  • locate_template does not check to see site has parent theme. @spacedmonkey
  • Unnecessarily check to see site is using a child theme in the theme functions. @spacedmonkey
  • Improve performance of get_block_theme_folders @spacedmonkey
• Image optimization logic dev note
  • https://core.trac.wordpress.org/ticket/58891 @felixarntz
  • https://core.trac.wordpress.org/ticket/58892 @felixarntz
  • https://core.trac.wordpress.org/ticket/58893 @felixarntz
  • https://core.trac.wordpress.org/ticket/58894 @felixarntz
  • https://core.trac.wordpress.org/ticket/58853 @felixarntz
• Optimizing autoloaded options dev note
  • https://core.trac.wordpress.org/ticket/58962 @felixarntz
  • https://core.trac.wordpress.org/ticket/58964 @felixarntz
  • https://core.trac.wordpress.org/ticket/51352 @felixarntz
• Script loading dev note
  • Use defer loading strategy for block view scripts @westonruter
  • Delay loading comment-reply script with async loading strategy @westonruter
  • Incorporate script loading strategies in bundled themes @westonruter
  • Eliminate manual construction of script tags @westonruter

[felixarntz]

I have updated the issue description with a few more Trac tickets after adding needs-dev-note to them, including grouping relevant tickets that should get one dev note together. I also added a Trac query link.

I am happy to pick up writing the two group dev notes, since I was heavily involved in both of these efforts.

cc @eclarke1 @joemcgill @spacedmonkey @mukeshpanchal27

[eclarke1]

@spacedmonkey are you ok to pick up the dev notes for:
https://core.trac.wordpress.org/ticket/52710
https://core.trac.wordpress.org/ticket/57296
https://core.trac.wordpress.org/ticket/57902

Then we just need to understand the right person to do the dev note for https://core.trac.wordpress.org/ticket/18298 - any suggestions on this one @felixarntz ?

[felixarntz]

@eclarke1 I'm not sure 18298 needs a full dev note. There's also the Field Guide post, which is suitable for shorter notes and explanations on notable changes that can be quickly explained in 1-2 sentences or at most a full paragraph.

Maybe we should change the ticket to use add-to-field-guide instead of needs-dev-note?

[felixarntz]

@spacedmonkey Could you update the issue description with the other 6.4 performance dev notes when you get a chance?

[spacedmonkey]

@eclarke1 @felixarntz @joemcgill I have updated the description with a list ticket and dev notes I think should be written.

Let me know if you agree and assign yourself to anything on the list that you feel you want to write about.

[felixarntz]

Thanks @spacedmonkey! Added myself to the image and optimized autoloaded options dev notes.

[spacedmonkey]

I made start on the object caching dev notes, if anyone wants to review.

https://docs.google.com/document/d/1dtrWzGHlzpcfaQG4wSHYtHkkzAbUScQiXeL968UKBTc/edit?usp=sharing

[spacedmonkey]

Remove usage of outputting styles tags @spacedmonkey

Dev note ready for review.
https://docs.google.com/document/d/1U3oupjW_UpZnBwut2Cyja6ElKHaiYzOEVc4Ynd0580c/edit?usp=sharing

[spacedmonkey]

Performance issues in _register_theme_block_patterns @spacedmonkey
locate_template does not check to see site has parent theme. @spacedmonkey
Unnecessarily check to see site is using a child theme in the theme functions. @spacedmonkey
Improve performance of get_block_theme_folders @spacedmonkey

Dev note ready for review.
https://docs.google.com/document/d/1avt7Yh_PArpD2NcUVKYxd4yUkTwDCGNCVhp6LmR1VUM/edit?usp=sharing

[westonruter]

Script loading dev note

• Use defer loading strategy for block view scripts @westonruter
• Delay loading comment-reply script with async loading strategy @westonruter
• Incorporate script loading strategies in bundled themes @westonruter
• Eliminate manual construction of script tags @westonruter

Ready for review: https://docs.google.com/document/d/1mOzcwLbCaQNbWOMGFj4H4MJPtIMz7Fs90uBwOQZbDS8/edit?usp=sharing

Public preview link: https://make.wordpress.org/core/?p=108934&preview=1&_ppp=f8ab32089f

[felixarntz]

I have completed drafts for the following dev notes:

• Image optimization logic dev note
• Optimizing autoloaded options dev note

I have also updated the issue description with the latest replies above, including links to the relevant dev note drafts.

@spacedmonkey I have also reviewed your dev notes for Object caching, and for Replacing hard coded style tags, those look good to me.

@westonruter Leaving feedback on your draft here since WP doesn't have inline commenting :)

• I would drop the "Summary:" from the very beginning. IMO unnecessary.
• Maybe add a paragraph / blank line after the first sentence?
• You link to the original script loading strategy dev note at the end, which is good, though I think it would be great to also include it inline somewhere earlier in the article (e.g. where you link to #12009, which is helpful but not as helpful, so I would somehow link to both the ticket and dev note there).

Otherwise looks great!

[westonruter]

@felixarntz Thanks! I actioned the first and third points. For the second point, the paragraph is intended to be a summary of the entire post, so I want to keep it concise in a single paragraph. I added a "The full details follow" text to the end of the paragraph to make that clear.

[eclarke1]

This is now complete, closing this issue out unless anyone has any other concerns?