Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wp-now: can't mount parent theme if it uses dispersed path #72

Open
wojtekn opened this issue Jun 8, 2023 · 3 comments
Open

wp-now: can't mount parent theme if it uses dispersed path #72

wojtekn opened this issue Jun 8, 2023 · 3 comments
Labels
Bug Something isn't working

Comments

@wojtekn
Copy link
Collaborator

wojtekn commented Jun 8, 2023

When we mount the parent theme in the theme mode, we expect it to be placed in the parent directory of the current theme directory. However, the 'Template' can be an absolute value, e.g., premium/my-child-premium-theme, and if it's the case, the wp-now can't find that theme.

Code reference:

`${documentRoot}/wp-content/${directoryName}/${templateName}`

We've spotted it with @robertsreberski today.

Done is

  • parent theme is automatically mounted if it's available, even if it uses a path that includes a subdirectory
@wojtekn wojtekn added the Bug Something isn't working label Jun 8, 2023
@danielbachhuber
Copy link
Member

I was wondering how long it would take for someone to run into this 😁

@lemanschik
Copy link

@danielbachhuber do i understand that correct that his issue is only there when you use the wp now theme only mode not when we use the whole wp folder? as i can not reproduce that with complet wp installs?

@danielbachhuber
Copy link
Member

do i understand that correct that his issue is only there when you use the wp now theme only mode not when we use the whole wp folder?

@lemanschik Correct, it's only a problem for theme mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants