Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add arguments to default node spawn method #1037

Merged
merged 1 commit into from
Feb 14, 2024
Merged

Add arguments to default node spawn method #1037

merged 1 commit into from
Feb 14, 2024

Conversation

mho22
Copy link
Contributor

@mho22 mho22 commented Feb 13, 2024

What is this PR doing?

Based on the issue #1032

packages/php-wasm/compile/php/phpwasm-emscripten-library.js on line 198:

if (ENVIRONMENT_IS_NODE) {
    return require('child_process').spawn(command, [], {
	shell: true,
	stdio: ['pipe', 'pipe', 'pipe'],
	timeout: 100,
    });
}

The spawn method should take args into account instead of an empty array.

...
    return require('child_process').spawn(command, args, {
...

@adamziel adamziel merged commit e7b5a00 into WordPress:trunk Feb 14, 2024
5 checks passed
@adamziel
Copy link
Collaborator

Thank you so much!

@mho22 mho22 deleted the add-arguments-to-default-node-spawn-handler-method branch February 15, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants