Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Google Analytics events to Playground #1040

Merged
merged 5 commits into from
Feb 26, 2024
Merged

Conversation

bgrgicak
Copy link
Collaborator

What is this PR doing?

This PR adds support for sending Google Analytics events.
Events are sent when the Playground website loads. There is a general load event to track the number of loads, and separate events for each step that send just the step name.

What problem is it solving?

We would like to better understand if people are using the features we build specifically what steps are used and how frequently.

How is the problem addressed?

By sending step names to Google Analytics we will be able to track the total number of times a step has been used and compare it to the number of events created.

Testing Instructions

@@ -34,6 +35,17 @@ export default function PlaygroundViewport({
storage,
});

// Add GA events for blueprint steps
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's document what is being logged and why.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a readme file with more details. Let me know if there is a better place to document this.

Copy link
Collaborator

@adamziel adamziel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left two nitpicks, but other than that we're good to merge so I'm approving this PR 🎉

@adamziel adamziel merged commit 454fec3 into trunk Feb 26, 2024
5 checks passed
@adamziel adamziel deleted the add/1022-ga-blueprint-events branch February 26, 2024 13:27
@bgrgicak
Copy link
Collaborator Author

Thanks for making these changes and merging!

@dmsnell
Copy link
Collaborator

dmsnell commented Feb 26, 2024

Is there no consent request before loading these? I believe we need to enqueue analytics until we ask for and receive consent.

@bgrgicak
Copy link
Collaborator Author

Analytics were already on the site, this PR just adds extra events. But that's a good point we should add a consent request.

@bgrgicak
Copy link
Collaborator Author

#1060

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants