Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build the php-wasm/util package as both ESM and CJS #1081

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Build the php-wasm/util package as both ESM and CJS #1081

merged 1 commit into from
Mar 5, 2024

Conversation

adamziel
Copy link
Collaborator

@adamziel adamziel commented Mar 5, 2024

Solves #1032 where the package cannot be require-d in node.js

Thank you for reporting @mho22 !

@adamziel
Build the php-wasm/util package as both ESM and CJS
8eca05f 
Solves #1032 where the package cannot be `require`-d in node.js
@adamziel adamziel added [Type] Bug An existing feature does not function as intended [Type] Repo / Project Management labels Mar 5, 2024
@adamziel adamziel merged commit 9b91b3e into trunk Mar 5, 2024
5 checks passed
@adamziel adamziel deleted the universal-build-php-wasm-util branch March 5, 2024 09:24
@adamziel adamziel mentioned this pull request Mar 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended [Type] Repo / Project Management
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@adamziel