Fix post_message_to_js memory out of bounds #1114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgrgicak
added
[Type] Bug
bgrgicak
commented
Mar 19, 2024
| @@ -396,7 +396,7 @@ PHP_FUNCTION(post_message_to_js) | |||
|
|
|||
| char *response; | |||
| size_t response_len = js_module_onMessage(data, &response); | |||
| if (response != -1) | |||
| if (response_len != -1) | |||
There was a problem hiding this comment.
JS returns -1 if there was an error processing the message to response_len. Checking response was the error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1112
What is this PR doing?
It fixes a bug in post_message_to_js that broke sending messages in Node.
What problem is it solving?
It checks if the response length of a message is larger than -1 before attempting to process the message.
How is the problem addressed?
By checking the response length.
Testing Instructions