Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs-site build #1222

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Fix docs-site build #1222

merged 2 commits into from
Apr 10, 2024

Conversation

bgrgicak
Copy link
Collaborator

@bgrgicak bgrgicak commented Apr 10, 2024 •
edited

What is this PR doing?

It fixes docs-site:build NX command.

What problem is it solving?

It resolves the root cause of npm run build failing.

How is the problem addressed?

By adding build-docs as a dependency of docs-site:build.

Testing Instructions

  • ensure all test pass

@bgrgicak bgrgicak self-assigned this Apr 10, 2024
@bgrgicak
Copy link
Collaborator Author

The docs build keeps failing with this error:

 Module not found: Error: Can't resolve './model.json' in '/home/runner/work/wordpress-playground/wordpress-playground/packages/docs/site/src'
[ERROR] Client bundle compiled with errors therefore further build is impossible.

@bgrgicak bgrgicak closed this Apr 10, 2024
@bgrgicak bgrgicak reopened this Apr 10, 2024
@bgrgicak
Copy link
Collaborator Author

To recreate this issue remove packages/docs/site/src/model.json from your machine, reset NX npm nx reset, and rebuild docs nx run docs-site:build --verbose.

@bgrgicak bgrgicak changed the title Fix build CI step Fix docs-site build Apr 10, 2024
@bgrgicak bgrgicak marked this pull request as ready for review April 10, 2024 08:27
@bgrgicak bgrgicak requested a review from adamziel April 10, 2024 08:27
@bgrgicak bgrgicak added [Type] Bug An existing feature does not function as intended [Type] Documentation Improvements or additions to documentation labels Apr 10, 2024
@bgrgicak
Copy link
Collaborator Author

E2E tests ara failing because of an unrelated issue:

[10-Apr-2024 08:31:21 UTC] PHP Parse error:  syntax error, unexpected '' (T_ENCAPSED_AND_WHITESPACE), expecting '-' or identifier (T_STRING) or variable (T_VARIABLE) or number (T_NUM_STRING) in /wordpress/wp-content/mu-plugins/sqlite-database-integration/wp-includes/sqlite/class-wp-sqlite-translator.php on line 3611

@adamziel adamziel merged commit 3c1a0d3 into trunk Apr 10, 2024
4 of 5 checks passed
@adamziel adamziel deleted the fix/ci-build branch April 10, 2024 10:25
adamziel added a commit that referenced this pull request Apr 11, 2024
@adamziel
Revert "Fix docs-site build (#1222)"
eb26af7 
This reverts commit 3c1a0d3.
@adamziel adamziel mentioned this pull request Apr 11, 2024
Merged
adamziel added a commit that referenced this pull request Apr 11, 2024
@adamziel
Revert changes to the docs build (#1226)
d135caf 
Undoes #1222 and
891bf3e to get the documentation site to build.

I am still unsure why does it sometime fail due to a missing
`models.json` file. Perhaps it skips the `build:json` part of the
process somehow? Let's keep observing the subsequent builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamziel adamziel Awaiting requested review from adamziel

Assignees

@bgrgicak bgrgicak

Labels
[Type] Bug An existing feature does not function as intended [Type] Documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bgrgicak @adamziel