Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WordPress: preserve PHP attributes and wp-config.php whitespace #964

Merged
merged 3 commits into from
Jan 22, 2024

Conversation

adamziel
Copy link
Collaborator

@adamziel adamziel commented Jan 22, 2024

What is this PR doing?

A part of #957

Ensures that PHP attributes like #[ Attr ] are preserved when minifying WordPress by using PHP 8.0 for minification. PHP 7.4 stripped them out as comments.

Testing instructions

Confirm the CI tests pass

@adamziel adamziel merged commit 0ea349f into trunk Jan 22, 2024
5 checks passed
@adamziel adamziel deleted the wp-remove-whitespace-using-php-8 branch January 22, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant