Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wp-cli: Respect quotes when parsing shell commands #966

Merged
merged 2 commits into from
Jan 22, 2024
Merged

Conversation

adamziel
Copy link
Collaborator

What is this PR doing?

Adds a naive shell command parser for the wp-cli demo.

It ensures that commands like wp option set blogname "My blog name" are split into

['wp', 'option', 'set', 'blogname', 'My blog name']

instead of

['wp', 'option', 'set', 'blogname', 'My', 'blog', 'name']

Testing Instructions

Go to http://localhost:5400/website-server/demos/wp-cli.html and confirm this works as advertised above.

@adamziel adamziel merged commit dc1dc5b into trunk Jan 22, 2024
4 checks passed
@adamziel adamziel deleted the parse_shell_args branch January 22, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant