Theme URI and Author URI

[ghost]

Theme URI and Author URI cannot be the same, which comes to..

users can bypass this if use a "/" at the end of a uri.

theme uri: http://www.domainname.com
author uri: http://www.domainname.com/

[emiluzelac]

Yep, as noted in: https://wordpress.slack.com/archives/themereview/p1428536051003175

[Otto42]

Seems a bit minor to me. But if you want to make a PR, I'll accept it.

Note that there is no current check to see if they're the same, that's one of the old hardcoded bits. Make a new check for it.

[carolinan]

Are there any links besides Theme URI with WordPress.org that we should disallow?

  <?php

class Check_URI implements themecheck {
    protected $error = array();

    function check( $php_files, $css_files, $other_files ) {

        checkcount();
        $ret = true;
        global $data;

        if ( !empty( $data['AuthorURI'] ) && !empty( $data['URI'] ) ) {

            if ( strtolower( preg_replace('/https?:\/\/|www./i', '', trim( $data['URI'] , '/' ) ) ) == strtolower( preg_replace('/https?:\/\/|www./i', '', trim( $data['AuthorURI'], '/' ) ) ) )  {
                $this->error[] = __('<span class="tc-lead tc-required">'.__('REQUIRED','theme-check').'</span>: '.__('Your Theme URI and Author URI should not be the same.', 'theme-check') );
            }

            //We allow .org user profiles as Author URI, so only check the Theme URI. We also allow WordPress.com links.
            if ( stripos( $data['URI'], 'wordpress.org' ) && $data[ 'AuthorName' ] <> "the WordPress team" ) {
                $this->error[] .= __('<span class="tc-lead tc-required">'.__('REQUIRED','theme-check').'</span>: '.__('Using a WordPress.org Theme URI is reserved for official themes.', 'theme-check') );
            }
        }

        return $ret;
    }

    function getError() { return $this->error; }
}
$themechecks[] = new Check_URI;

[Otto42]

You could add in the w.org domain as well, since it redirects.

[carolinan]

Actually perhaps this should be combined with links.php in one file.