Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use "Heading" in place of "Header" when technically accurate #77

Open
mrwweb opened this issue May 9, 2023 · 0 comments · May be fixed by #78
Open

Use "Heading" in place of "Header" when technically accurate #77

mrwweb opened this issue May 9, 2023 · 0 comments · May be fixed by #78

Comments

@mrwweb
Copy link

mrwweb commented May 9, 2023

Since the WordPress interface correctly uses "Heading" for h1, h2, etc. the theme unit test content should also use "Heading". In many cases, it currently uses "Header" which can mean a page region or type of content, either semantic (the <header> element) or generic.
mrwweb referenced this issue in mrwweb/theme-test-data May 12, 2023
@mrwweb
Standardize text to describe headings
f657fdc 
Standardize text used with displaying headings so it's always "Heading #" (not "Header #" or "H# Heading")

Closes #77
@mrwweb mrwweb linked a pull request May 12, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Standardize text to describe headings mrwweb/theme-test-data
1 participant
@mrwweb