This repository has been archived by the owner on Jan 15, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 167
Optimize font styling #350
Labels
Comments
Or, like in Twenty Seventeen,
|
@joyously I mean in a general sense and not language specific. |
I know, but why not? We did that in Twenty Seventeen. |
The discussion for that should be done in #29 The point of this issue is reduce the number of classes used to define header fonts. |
Yeah, I like this idea @grappler 👍 . The selectors could certainly be slimmed down in |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
While looking at #344 I saw there were multiple classes being used to define the header font styles.
This caused me to look at the default styles. For the heading styles we have loads of classes that have a custom header font. This does not seem very clean and organised.
twentynineteen/sass/typography/_headings.scss
Lines 1 to 20 in b5a5019
I am not a CSS expert but I feel we can optimise the CSS. For example do we need
h2.author-title
andh2
or.error-404 .page-title
and.not-found .page-title
where.page-title
may suffice.The font family is being defined twice for
.page-description
.It should be nearly possible to just have.
The text was updated successfully, but these errors were encountered: