Skip to content
This repository has been archived by the owner on Jan 15, 2019. It is now read-only.

horizontal rule is barely there #83

Closed
joyously opened this issue Oct 16, 2018 · 4 comments
Closed

horizontal rule is barely there #83

joyously opened this issue Oct 16, 2018 · 4 comments
Labels
enhancement New feature or request move to trac

Comments

@joyously
Copy link

The styles for <hr> make the element very short. When I look at the styles, it says
max-width: 2.25em
That's tiny and would be very unexpected for legacy content.

@kjellr
Copy link
Collaborator

kjellr commented Oct 17, 2018

The theme actually ships with three hr styles, all accessible via Gutenberg block variants:

screen shot 2018-10-17 at 12 41 40 pm

For the purpose of preserving the expected visual appearance in legacy content, I'm fine with reverting to the middle version for hrs that don't have the wp-block-separator class.

@kjellr kjellr added the enhancement New feature or request label Oct 17, 2018
@joyously
Copy link
Author

That would be a good way to do it.

@mrwweb
Copy link

mrwweb commented Nov 1, 2018

The default style is redundant with the line above the H2. Given that HR's and H2s are both used to denote major changes in content within a document, it makes sense for the theme to support them used in conjunction out of the box. I'd flip the 1st and 2nd styles.

@laurelfulford
Copy link
Collaborator

Closing this ticket, as it's been moved to Trac here: https://core.trac.wordpress.org/ticket/45912

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request move to trac
Projects
None yet
Development

No branches or pull requests

4 participants