Skip to content
This repository has been archived by the owner on Dec 1, 2019. It is now read-only.

alignleft and alignright miscalculated #315

Closed
joyously opened this issue Sep 17, 2019 · 4 comments · Fixed by #326
Closed

alignleft and alignright miscalculated #315

joyously opened this issue Sep 17, 2019 · 4 comments · Fixed by #326

Comments

@joyously
Copy link

The fix for #231 caused a worse issue.
The alignleft and alignright classes have negative margins that pull them off screen.
This screenshot is from my normal desktop window size of 1020px.
alignment-off-screen

And when I make the window narrower, they disappear altogether, until right around 690px.
This screenshot is at 694px.
alignment-off-screen-700
@carolinan carolinan added the RTL label Sep 17, 2019
@andersnoren andersnoren mentioned this issue Sep 17, 2019
Merged
@andersnoren andersnoren removed the RTL label Sep 17, 2019
@joyously
Copy link
Author

It seems that #326 causes this problem, not fixes it.
I think this issues is still an issue.

@andersnoren
Copy link
Contributor

@joyously #326 fixes this in all browsers (including IE11) for me. Is it not fixed for you?

@joyously
Copy link
Author

When the margin is -31rem, I get the screenshots above on those window sizes. It looks to me like 326 has that margin.

@joyously
Copy link
Author

I just redownloaded the master, and it looks fixed now. Not sure why.
Sorry.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix .alignleft and .alignright on tablet and up andersnoren/twentytwenty
3 participants
@carolinan @joyously @andersnoren