Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Font size declarations need to be updated #912

Closed
robincornett opened this issue Oct 22, 2019 · 3 comments

Comments

@robincornett
Copy link

@robincornett robincornett commented Oct 22, 2019

I've opened a related issue on the main Gutenberg repository, but with WP5.3 coming sooner and no response there, I'm raising the issue here as well.

It appears that the block editor/Gutenberg set normal as the fallback, or default font size. If that size has not been defined, when a block is opened or selected, the font size picker shows the first defined font size, as if it were the selected font size for the block, which is not necessarily the case. There are other issues stemming from using normal instead of an empty value as a fallback, but hopefully the Gutenberg team will pursue those.

For Twenty Twenty, I suggest that the regular font size be renamed to normal to be consistent with the block editor fallbacks.

@carolinan

This comment has been minimized.

Copy link
Contributor

@carolinan carolinan commented Oct 22, 2019

Hi,
Yes this is a known issue that will need to be solved after 5.3 because we are in a string freeze where we cannot update the text.

@robincornett

This comment has been minimized.

Copy link
Author

@robincornett robincornett commented Oct 22, 2019

The issue is with the slug, not with the text string. Fixing the slug would prevent a selected block from showing "Small" as the current block font size, when a font size has not been set, even if the slug and text string label are different until a fix can be implemented.

@pattonwebz

This comment has been minimized.

Copy link
Member

@pattonwebz pattonwebz commented Nov 10, 2019

Hey @robincornett thank you for reporting this. To work around the issue for the moment I swapped the slug on the Regular font size to normal which allows alphabetical sorting to take over. It's not an ideal solution but it looks as though the theme will need to work around this as upstream still does not have a fix.

I created and merged this PR which resolves this on our end: #989

@pattonwebz pattonwebz closed this Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.