Skip to content
This repository has been archived by the owner on Jan 24, 2024. It is now read-only.

border-radius consistency across all patterns #363

Closed
4 tasks
colorful-tones opened this issue Sep 13, 2023 · 3 comments
Closed
4 tasks

border-radius consistency across all patterns #363

colorful-tones opened this issue Sep 13, 2023 · 3 comments
Labels
[Type] Bug Something isn't working

Comments

@colorful-tones
Copy link
Member

colorful-tones commented Sep 13, 2023

Description

It is recommended we set settings.custom.border.radius to control a consistent border-radius value throughout patterns. Right now, I'm seeing a lot of "border":{"radius":"16px"} in patterns. So, maybe we go with 16px? Either way, it should reference a variable.

We could also consider utilizing an existing spacing preset. Like @richtabor did in c7f123d

Also, someone should run through the theme.json and look to streamline values to variable.

Here is a list of affected patterns that would need to be updated:

  • centered-statement.php
  • clients.php
  • cta.php
  • pricing.php

Maybe testimonial.php as well? I'm seeing "border":{"radius":"999px"}

@richtabor
Copy link
Member

Right now, I'm seeing a lot of "border":{"radius":"16px"} in patterns.

If it's a block that does not support rounded, that's what's used. Perhaps we add block style variations for those few block, like image had "rounded"?

@MaggieCabrera
Copy link
Collaborator

Right now, I'm seeing a lot of "border":{"radius":"16px"} in patterns.

If it's a block that does not support rounded, that's what's used. Perhaps we add block style variations for those few block, like image had "rounded"?

I think that makes it more consistent, yes

@MaggieCabrera
Copy link
Collaborator

We changed this so we are using a preset variable so I'm closing this one

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
[Type] Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants