-
Notifications
You must be signed in to change notification settings - Fork 117
Add initial block patterns #50
Comments
Question on best practice: Should images be included in patterns, or be empty? |
I don't know that the alternating posts pattern from Seedlet works stylistically with this theme, so I'd remove it.
Do we know who the best person to answer this question is? |
Anyone have ideas for how to implement the font-weight setting for this one? Block patterns don't come with their own CSS class, so we can't assign it in the stylesheet. And selecting a light font weight is not possible in the editor currently. 🤔 We could add a custom class ourselves, but I feel like users aren't going to notice that's there and it may cause confusion. |
Yeah, we might be out of luck there 😕 |
When you say, we can add the custom class ourselves, do you mean using the additional CSS class field? |
Yeah, it's a hack. Users definitely won't know it's there. |
Couldn't a light font weight be part of a paragraph block style? |
Yeah — using a block style of it feels a little weird in general, but you make a great point about how some system fonts in the stack may actually not have a light variant to swap out with. In that case, the user wouldn't notice any difference between the normal + "Light" block styles. 😕 |
Yeah, we might just need to go with regular weight here. |
Why do users need to know that the additional class is there? It is not a problem for other block styles, like |
Is adding a class to patterns something that you want to move over to the Gutenberg repo? |
That class is added via a block style though, so while it is invisible to the user, they have standard Gutenberg UI to add and remove it.
I don't think so. There is a standard practice for doing so (block styles). The problem is mostly that it doesn't quite make sense for us to adopt that for font weight here. There's already a PR for font-weight, and that's all we need to get this implemented in a standardized way: WordPress/gutenberg#24978. |
Block patterns can add CSS class names that are visible in the additional CSS class field too. |
Since we're finding that it'll be difficult to do text overlaps, it might be nice to sub in this one instead:
|
This should be good now! Closing. |
Twenty Twenty One will come packaged with several block patterns. Here's a couple to get us started.
You can view all of these block patterns in Figma: https://www.figma.com/file/OEtsCj8oD8JPVx4OvsS0U2/Twenty-Twenty-One?node-id=269%3A68
As more pattern designs come in, we'll likely end up modifying or removing some of these initial patterns, but they should be good to get us started.
The text was updated successfully, but these errors were encountered: