Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Dark Mode: Reduce image brightness & contrast #618

Closed
melchoyce opened this issue Oct 20, 2020 · 7 comments
Closed

Dark Mode: Reduce image brightness & contrast #618

melchoyce opened this issue Oct 20, 2020 · 7 comments
Assignees
Labels
Projects

Comments

@melchoyce
Copy link
Contributor

Describe the bug
In dark mode, images appear brighter because they're against a dark background, which can cause eye strain. What if we reduced the brightness and contrast to make images easier on the eyes?

Screenshots

Before After
image image

This uses:

filter: brightness(.85) contrast(1.1);

Additional context
This is a suggestion in https://css-tricks.com/a-complete-guide-to-dark-mode-on-the-web/.

@carolinan
Copy link
Contributor

I am not a dark mode user, but I would not expect this.
If I wanted a filter over my images, I would want to decide that myself, and I would use a cover block.

@hedgefield
Copy link

hedgefield commented Oct 21, 2020

I've seen this method used more often in dark mode themes yeah, also by reducing saturation a little bit. I don't find it such a bad idea, I have certainly had my eyes hurt from bright colorful images during a dark mode situation. But I can imagine if images are super important on your site, or you already authored them to look good in a dark mode theme, you'd be peeved that there's something in the theme that messes with them. It's probably not trivial to put this behind a theme option toggle huh? I like the feature, but feels like something that each theme user should be able to opt into or out of.

@ryelle
Copy link
Collaborator

ryelle commented Oct 21, 2020

There are other discussions ongoing in other issues, but there already is a theme option that site owners can use to turn off prefers-color-scheme support. So if the design/images are very important, they can turn it off.

@hedgefield
Copy link

Wouldn't that disable dark mode entirely?

@aristath
Copy link
Member

yes, it would.

@aristath
Copy link
Member

During Friday's meeting it was decided to remove everything related to dark-mode and instead put that feature in a plugin as a safety precaution. dark-mode was removed in #690 and moved in a plugin, with the hope that it can be re-integrated in the theme if we're satisfied with its implementation.
Closing this issue.

@carolinan
Copy link
Contributor

This is already included, closing.

TT1 automation moved this from Backlog to Done Nov 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
TT1
Done
Development

No branches or pull requests

5 participants