Skip to content
This repository has been archived by the owner on Dec 2, 2020. It is now read-only.

Dark Mode: Should we reduce the opacity of borders, dividers, and separators? #620

Closed
melchoyce opened this issue Oct 20, 2020 · 5 comments · Fixed by #809
Closed

Dark Mode: Should we reduce the opacity of borders, dividers, and separators? #620

melchoyce opened this issue Oct 20, 2020 · 5 comments · Fixed by #809

Comments

@melchoyce
Copy link
Contributor

melchoyce commented Oct 20, 2020

Describe the bug
Slightly darker borders would help reduce eye strain from too much contrast, and would also blend in better with the dark color scheme.

Screenshots

Before After
image image
Before After
image image

Additional context
This idea comes from https://css-tricks.com/a-complete-guide-to-dark-mode-on-the-web/.

@melchoyce
Copy link
Contributor Author

I used 30% opacity in the above "after" screenshots, but we'd want to use an opacity that still lets us meet 4.5:1 contrast — maybe 55%?

@carolinan
Copy link
Contributor

This was already tested once and not implemented.

@hedgefield
Copy link

I agree this looks better, puts more visual emphasis on what's actually important on the page. I think @carolinan was referring to #155, I asked her about it and she's in favor of doing this, so yay 🎉 The AAA contrast ratio is important still yeah, so if 55% works for that, great 👍

@carolinan carolinan added this to Backlog in TT1 via automation Oct 23, 2020
TT1 automation moved this from Backlog to Done Oct 26, 2020
@carolinan
Copy link
Contributor

It was decided to not include this without the (device) dark mode support.

@carolinan
Copy link
Contributor

Changing the input fields background color would also mean that we had to adjust the text, and it would be confusing to have different colors here depending on if the field is empty, has content, or is being edited.

The current color for inputs when the dark backgrounds are used is somewhat darker than the full white, and keeps the contrast ratio with the text color.
--global--color-white-90: rgba(255, 255, 255, 0.9);

@carolinan carolinan moved this from Backlog to Development done (needs code review) in TT1 Nov 9, 2020
TT1 automation moved this from Development done (needs code review) to Done Nov 9, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
TT1
Done
Development

Successfully merging a pull request may close this issue.

3 participants