This repository has been archived by the owner on Oct 28, 2022. It is now read-only.
Swap post-author-name for post-author block #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikachan
approved these changes
Sep 30, 2022
There was a problem hiding this comment.
Thank you for highlighting this and creating a PR! After reading through WordPress/gutenberg#44618, this LGTM.
|
I'll circle back and close out #44618 if/when this gets merged. Thanks! |
|
The aubergine style variation also styles the post-author-name block, so it may need to be updated. |
carolinan
approved these changes
Oct 3, 2022
|
I've updated the Aubergine variation so that these styles work with the post-author block. Thanks both, I'll bring this in! |
|
Good catch on Aubergine. Thanks @carolinan @mikachan |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes upstream change noted here: WordPress/gutenberg#44618