Skip to content
This repository has been archived by the owner on Jan 26, 2022. It is now read-only.

Include the flying bird image in the homepage header #92

Closed
kjellr opened this issue Oct 12, 2021 · 4 comments · Fixed by #183
Closed

Include the flying bird image in the homepage header #92

kjellr opened this issue Oct 12, 2021 · 4 comments · Fixed by #183

Comments

@kjellr
Copy link
Collaborator

kjellr commented Oct 12, 2021

The original mockup for the theme includes this flying bird image on the homepage template:

Screen Shot 2021-10-12 at 1 33 06 PM

This has been left out for now while we figure out the best way to include it. Here's the situation:

Normally, we'd bundle this image in the theme files and refer to it in the PHP templates. This isn't possible in block templates, since the image block can't take a dynamic URL. It will work fine in patterns though, where we can use PHP to find the right path. So a workaround like #56 may be possible.

We could put it up on the WP.org CDN, or in the Pattern Directory's media library, and hotlink to it. But it feels non-ideal to have to require that 3rd-party request by default on the front-end.

I think there's also something to be said about not including this image here by default, since approx 99% of folks will not actually keep this bird image on the front page of their website. 😂

I'm opening this issue for discussion and to find a solution one way or another.

@carolinan
Copy link
Collaborator

Upstream issue: WordPress/gutenberg#31815

@MaggieCabrera
Copy link
Collaborator

Well, if the pattern block actually ends up making it, that would solve it, right? A pattern block ends up being the solution to so many things!

@kjellr
Copy link
Collaborator Author

kjellr commented Oct 20, 2021

Yeah, the pattern block would solve it, but it seems like a weird workaround to me. 🤔

@kjellr
Copy link
Collaborator Author

kjellr commented Oct 29, 2021

This should now be possible by using the Pattern block. I'm changing this issue's title + tags as a result.

@kjellr kjellr added this to the Feature Freeze milestone Oct 29, 2021
@kjellr kjellr changed the title Figure out how to include the flying bird image in the homepage header Include the flying bird image in the homepage header Oct 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants