File block: Re-add frontend styles for classic themes #4045
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellofromtonya
approved these changes
Feb 13, 2023
There was a problem hiding this comment.
- Confirmed File block: Re-add editor styles for classic themes gutenberg#47686 is in this PR ✅
- Works as expected (see test report) ✅
Ready for commit 👍
|
Committed via https://core.trac.wordpress.org/changeset/55323. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket: https://core.trac.wordpress.org/ticket/57688
This PR adds text color and background color to the file block on the frontend, which is lost in the Classic theme.
Testing Instruction
Classic themes such as Twenty Twenty One and Twenty Twenty cannot be reproduced because they have styles for file blocks. Therefore, create a plain theme with the following files:
empty-classic/style.css
empty-classic/index.php
<?php wp_head(); the_post(); the_content(); wp_footer();Before
After