Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export to GitHub causes page refresh and lost changes if you don't store in browser #1039

Closed
annezazu opened this issue Feb 14, 2024 · 2 comments
Labels
[Aspect] Browser [Type] Bug An existing feature does not function as intended
Milestone

Comments

@annezazu
Copy link

Something seems to have changed with Playground and exporting to GitHub. Yesterday, I lost an entire custom setup when exporting because it seems to have reloaded the page when I hit export to github. Here's a quick video replicating:

refresh.mov

To explain, I started a new playground instance, imported a pattern, changed, a style variation, then clicked on "export to GitHub". In the background, it refreshes the instance causing all changes to be lost. To get around this, I needed to store changes in the browser.

@adamziel adamziel added this to the Zero Crashes milestone Mar 12, 2024
@adamziel adamziel added [Type] Bug An existing feature does not function as intended [Aspect] Browser labels Mar 12, 2024
@adamziel
Copy link
Collaborator

adamziel commented Mar 12, 2024

@annezazu the modal warns against that specific scenario and asks to export Playground before proceeding – did you mean the modal wasn't there and the page just reloaded without warning? Or did you mean the modal doesn't communicate the reload problem clearly enough?

@annezazu
Copy link
Author

Oh wow. Before, I don't remember this happening when I exported to GitHub so assumed something changed. Maybe I'm just not remembering correctly. I'll close this out in that case :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Aspect] Browser [Type] Bug An existing feature does not function as intended
Projects
Archived in project
Development

No branches or pull requests

2 participants