Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Advanced blueprint.json code block incomplete #1110

Closed
flexseth opened this issue Mar 17, 2024 · 8 comments
Closed

Advanced blueprint.json code block incomplete #1110

flexseth opened this issue Mar 17, 2024 · 8 comments
Assignees
Labels
[Type] Bug An existing feature does not function as intended [Type] Documentation Improvements or additions to documentation
Milestone

Comments

@flexseth
Copy link
Collaborator

flexseth commented Mar 17, 2024

Reported from Slack, there are duplicates of this issue across various repos I can work to get closed out once the PR is merged. If not merged, and automatic syncing happens at some point, the changes will be reverted

Otherwise this is fixed but I'll keep the issue open until it's addressed across the board

I found a bug in this docs. In this article, the code block is unfinished: https://developer.wordpress.org/plugins/wordpress-org/previews-and-blueprints/#blueprints

Link to doc in question

Second blueprint on the page

Here’s an example of a more advanced blueprint.json that demonstrates some more features you could use to create a rich demo environment for users:

{
    "landingPage": "/wp-admin/post.php?post=5&action=edit",
    "preferredVersions": {
        "php": "7.4",
        "wp": "5.9"
    },
    "phpExtensionBundles": [
        "kitchen-sink"
    ],
    "steps": [
        {
            "step": "login",
            "username": "admin",
            "password": "password"
        },
        {
            "step": "installPlugin",
            "pluginZipFile": {
                "resource": "wordpress.org\/plugins",
                "slug": "my-imaginary-plugin-dependency"
            },
            "options": {
                "activate": true
            }
        },
        {
            "step": "installPlugin",
            "pluginZipFile": {
                "resource": "wordpress.org\/plugins",
                "slug": "my-imaginary-plugin"
            },
            "options": {
                "activate": true
            }
        },
        {
            "step": "installTheme",
            "themeZipFile": {
                "resource": "wordpress.org\/themes",
                "slug": "my-imaginary-theme"
            }
        },
        {
            "step": "setSiteOptions",
            "options": {
                "some_required_option_1": "your_favorite_values",
                "some_required_option_2": "your_favorite_values"
            }
        },
        {
            "step": "runPHP",
            "code": " 5,\n'post_title' => 'Example Post',\n'post_content' => '
@adamziel adamziel added [Type] Bug An existing feature does not function as intended [Type] Documentation Improvements or additions to documentation labels Mar 21, 2024
@adamziel adamziel added this to the Devrel milestone Mar 21, 2024
@adamziel
Copy link
Collaborator

adamziel commented Mar 21, 2024

Thank you for surfacing this here! I reported this on meta.trac.wordpress.org where that page is discussed: https://meta.trac.wordpress.org/ticket/7487#comment:6

@theMikeD
Copy link

theMikeD commented Apr 1, 2024

This change was made to the Plugin Handbook.

@adamziel
Copy link
Collaborator

adamziel commented Apr 2, 2024

Looks good on my end – closing this issue.

CleanShot 2024-04-02 at 15 42 24@2x

@adamziel adamziel closed this as completed Apr 2, 2024
@adamziel
Copy link
Collaborator

adamziel commented Apr 2, 2024

@flexseth said:

The PR in this issue needs to be merged, so when the handbook auto-syncs, the change I made isn't overwritten

Let's keep this issue open until that happens.

@adamziel adamziel reopened this Apr 2, 2024
@flexseth flexseth removed the Blocked label Apr 3, 2024
@colorful-tones
Copy link
Member

@flexseth I'm not privy to the auto-sync that needs to happen or where/how that happens. Thanks for getting this all wrangled together. I wanted to see if the auto-sync happened or if there is anything I can do (or ping) to close this out.

@flexseth
Copy link
Collaborator Author

flexseth commented Apr 4, 2024

@flexseth I'm not privy to the auto-sync that needs to happen or where/how that happens.

Some of the handbooks sync SVN to the WordPress.org websites. The code I submitted had been manually updated, but if the PR wasn't merged, the sync would overwrite the changes that were correct on the Plugins Handbook on wp.org

Everything sync'd automatically until recent, but it's paused while discussion goes on around a better workflow for the handbooks

For now I think @adamziel wants to keep the issue open for posterity! Hopefully really soon there will be a proof of concept for how a handbook can look with Playground

@colorful-tones
Copy link
Member

Really appreciate the additional context @flexseth 🤘

@flexseth
Copy link
Collaborator Author

Let's keep this issue open until that happens.

Got it done. Marking as closed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Bug An existing feature does not function as intended [Type] Documentation Improvements or additions to documentation
Projects
Status: Done
Development

No branches or pull requests

4 participants