Redirect /wp-admin to /wp-admin/ as not to break the admin navigation menu

[KeesCBakker]

When I use http://127.0.0.1:8881/wp-admin, I get a nice page:

But all of my links of my menu break:

So I end up on the wrong page:

Easy solution: redirect /wp-admin to /wp-admin/. Looks like my "normal" WordPress does this by itself.

[KeesCBakker]

Come to think of it, this might be some kind of PHP.ini or http config apache thingy, where it appends a trailing slash to some paths...

[adamziel]

Playground in the browser handles that in the address bar handler. A better solution would involve an isomorphic WordPress request handler for all Playground consumers.

[dmsnell]

@KeesCBakker I think so, because when I run WordPress locally with php -S it does the same thing. I've "found out" a couple times why it happens, but I always forget why. I think you are right with the /. That is to say, this is not caused by the Playground; probably a quirk exposed by these less-common environments in which WordPress runs.

Maybe we could find the culprit in some server config and set that as a Playground default.

[sejas]

• I created a PR that adds this redirection. wp-now: add wp-admin redirection with trailing slash playground-tools#60

[adamziel]

Reopening since there is a fix in wp-now, but there isn’t yet a general fix that would work for all Playground-based apps.

[KeesCBakker]

@sejas thanks for fixing this!

[eliot-akira]

a general fix that would work for all Playground-based apps

The Playground client's goTo() method specifically rewrites /wp-admin to /wp-admin/.

if (requestedPath === '/wp-admin') {
	requestedPath = '/wp-admin/';
}
wpFrame.src = await playground.pathToInternalUrl(requestedPath);

(In packages/playground/remote/src/lib/boot-playground-remote.ts)

It seems that solves the issue in general, at least on the browser side. Except for Playground-based apps that set the iframe src directly instead of using goTo().

[adamziel]

@eliot-akira I was thinking about some rewriting mechanism at the request handler level to also support nice permalinks regardless of how that request reached WordPress. At the moment, building a wp-now clone would require reimplementing the rewriting logic.

[eliot-akira]

rewriting mechanism at the request handler level

That makes sense to solve it deeper in the core, so that "consumers" like wp-now, the Playground client's goTo method, or the address bar, don't need to work around it.

I think rewriting URL to add a trailing slash automatically is often done by server configuration. Come to think of it, it's weird that /wp-admin results in broken links in the admin menu. It seems like something that should be handled by WordPress itself (like redirect to canonical URL), instead of relying on Apache/NGINX, a php.ini directive, or the Playground's request handler to add the slash.

[sejas]

I am unassigning myself from this issue because I don't have the bandwidth to move it forward in the near future.
I agree that a fix on Core would be a more general fix.

[brandonpayton]

This was fixed by #1539 in a general way here:

wordpress-playground/packages/php-wasm/universal/src/lib/php-request-handler.ts

Lines 360 to 370 in 093e082

	// This behavior is also necessary for WordPress to function properly.
	// Otherwise, when viewing the WP admin dashboard at `/wp-admin`,
	// links to other admin pages like `edit.php` will incorrectly
	// resolve to `/edit.php` rather than `/wp-admin/edit.php`.
	if (!fsPath.endsWith('/')) {
	return new PHPResponse(
	301,
	{ Location: [`${requestedUrl.pathname}/`] },
	new Uint8Array(0)
	);
	}