Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a place to paste a Blueprint to spin a new Playground instance #739

Closed
adamziel opened this issue Nov 13, 2023 · 7 comments
Closed

Comments

@adamziel
Copy link
Collaborator

adamziel commented Nov 13, 2023

Blueprints can be pasted after the URL hash, as in https://playground.wordpress.net/#{"preferredVersions":{....

This is a bit of an arcane knowledge. There should be an easily accessible textarea somewhere that also offers some validation on the spot.

CC @mtias

@adamziel
Copy link
Collaborator Author

Related WordPress/blueprints#42

@adamziel
Copy link
Collaborator Author

@sejas built https://sejas.es/playground and the source code is available at https://github.com/sejas/playground-blueprint-builder

@adamziel
Copy link
Collaborator Author

adamziel commented Nov 18, 2023

@seanmorris extended @sejas work and added autocompletion: https://seanmorris.github.io/playground-blueprint-builder/ ❤️ I noted some accessibility issues on mobile, likely coming from the Ace editor itself. Maybe they can be fixed, or maybe the answer is to switch to CodeMirror which didn't have those problems.

@adamziel
Copy link
Collaborator Author

Related discussions:

In particular this comment from @ajitbohra:

would love to contribute. The repo is public https://github.com/lubusIN/wp-playground-blueprint-builder/ need to iron out a few issues.

@sejas had an idea to integrate the Blueprint building experience with the https://playground.wordpress.net/ app – let's coordinate our efforts around the builder experience.

@adamziel
Copy link
Collaborator Author

adamziel commented Nov 19, 2023

Some notes about what @seanmorris built:

  • ✔️ It would be useful to re-run the blueprint with cmd+s (or ctrl+s on windows)
  • ✔️ It would be nice to jump after the terminating quote " after choosing the autocomplete suggestion
  • ✔️ In v2 would be lovely if it autocompleted plugins and themes names
  • ✔️ It's a pretty slick experience

But first let's see if we can make Ace mobile-friendly. If not, it doesn't make much sense to invest in UX enhancements before switching to CodeMirror.

Also, I noticed it sometimes gets stuck and I don't know why – it could be a Playground issue, but I haven't seen that behavior in other contexts:

CleanShot 2023-11-19 at 14 36 18@2x

@seanmorris seanmorris changed the title Create a place to paste a Blueprint to spin a new Playground instance As a developer, I can load a web UI to edit a Blueprint stanza and run it in a playground instance right on the page. Nov 22, 2023
@adamziel adamziel changed the title As a developer, I can load a web UI to edit a Blueprint stanza and run it in a playground instance right on the page. Create a place to paste a Blueprint to spin a new Playground instance Nov 23, 2023
@seanmorris
Copy link
Contributor

@adamziel Is this done?

@adamziel
Copy link
Collaborator Author

@seanmorris The builder will sometimes stop progressing and never return success or failure. I'd keep this issue open once that's addressed since it's a blocking problem. I just opened #863 to track that problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants