Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the updated i6 design using @wordpress/components #357

Open
Sephsekla opened this issue Jun 27, 2023 · 1 comment
Open

Implement the updated i6 design using @wordpress/components #357

Sephsekla opened this issue Jun 27, 2023 · 1 comment
Labels
javascript Pull requests that update Javascript code [Scope] UI - Notification Hub
Projects

Comments

@Sephsekla
Copy link
Collaborator

What problem does this address?

We have a new design available at https://www.figma.com/file/sC0QzxbY1Azm6wtc2X6bXV/WP-Notify-design-blueprints-i6-(by-Nick-Heurter)?type=design&node-id=158%3A105&t=kODRNurZMamE3Fbz-1, which makes better use of existing components in WordPress Core.

What is your proposed solution?

Update the Hub implementation to use this updated design.

Please confirm that you have searched existing issues in the repo.

Yes

@folletto
Copy link
Collaborator

I appreciate the redesign to align with Gutenberg components. Nice work overall :)

A couple of things.

(1) What's the reason for using a modal for settings here?
It seems very important, and very much aligned with WordPress modularity, to have a page that can be reached to configure the Notification. Especially as the settings area is expected to grow in future iterations a lot with per-plugin settings.

(2) Any reason for this to be changed to a dropdown instead of a sidebar as the original design?
Gutenberg should have sidebar designs no? A sidebar design would allow for more space and more flexibility, which is why it was chosen at the time. What's the current thinking?

(3) Is there any evolved solution for all the on-page variants?
Maybe this was decided elsewhere to be dealt differently, or skipped for the first release, but it was a very delicate point at the time and we did a lot of work to make a proposal that could balance off all the criteria.
What is the current thinking about the red banner (also, does it pass accessibility? seems very low contrast)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Pull requests that update Javascript code [Scope] UI - Notification Hub
Projects
Development

No branches or pull requests

2 participants