Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handbook: Import the post_modified from last Github commit date #464

Closed
dd32 opened this issue Jan 8, 2024 · 1 comment · May be fixed by WordPress/wordpress.org#203
Closed

Handbook: Import the post_modified from last Github commit date #464

dd32 opened this issue Jan 8, 2024 · 1 comment · May be fixed by WordPress/wordpress.org#203

Comments

@dd32
Copy link
Member

dd32 commented Jan 8, 2024

Per #456 the last modified date of github-imported handbooks can be incorrect.

While the above issue has been closed via a once-off fix, we should move forward with querying the last commit upon markdown import, such that the dates (which are now prominently displayed) are accurate.

To make it work with standalone environments, as well as production, we can use a GitHub App if available and fall back to unauthenticated API requests if not. That should likely be enough to mostly-work™ for local testing, while working perfectly in production.

Note: The markdown importer is not contained within this repo, but this is the primary place it's used and this bug is visible. The source is here: https://github.com/WordPress/wordpress.org/tree/trunk/wordpress.org/public_html/wp-content/plugins/wporg-markdown

@renintw
Copy link
Contributor

renintw commented Feb 19, 2024

For some unknown reason, the deprecated PR link in the development section on the right side of this page is unable to be removed, and the attempt to remove them has messed up the page.. So closing this issue and opening another one to keep it clean. #505

@renintw renintw closed this as completed Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment