Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use is_host from attendees table instead of post_author to determine who is a host #199

Closed
psrpinto opened this issue Apr 9, 2024 · 6 comments
Assignees

Comments

@psrpinto
Copy link
Member

psrpinto commented Apr 9, 2024

In #172 we made it so that the attendees table has an is_host field. However, this field is not yet being used everywhere to determine who is the host of an event.

We need to go over all places in the code where we use the post_author(or $event->author_id()) to tell who is the host of an event, and change it so that it uses is_host from the attendees table instead.

@psrpinto psrpinto added this to the Second Test Event milestone Apr 9, 2024
@psrpinto
Copy link
Member Author

psrpinto commented Apr 9, 2024

Related to #178

@akirk
Copy link
Collaborator

akirk commented Apr 10, 2024

@amieiro this will solve the permissions problem you'll be facing in #200

@psrpinto
Copy link
Member Author

I intended to take this issue, but I noticed it would need code that is being introduced in #200, so I think we should wait for #200 to be merged before tackling this one.

It could also be that #200 actually also fixes this issue. Once #200 is merged, we should check whether this issue is still relevant or not.

@psrpinto psrpinto added this to the Second Test Event milestone Apr 11, 2024
@trymebytes
Copy link
Collaborator

@psrpinto is it okay to close this?

@psrpinto
Copy link
Member Author

I'm currently double-checking this, will close once I've confirmed it.

@psrpinto
Copy link
Member Author

I've now confirmed this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants